Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes up to bf153b384b76c7e7f5b3e6b93a6d2ce36cd60f75 #2590

Merged

Conversation

ClearlyClaire
Copy link

Probably the last merge in a while considering the huge compose redesign upstream made.

Conflicts

  • app/controllers/auth/confirmations_controller.rb:
    Upstream refactored, changing lines textually close of glitch-soc-only lines
    pertaining to the theming system.
    Resolved the conflict.
  • app/controllers/auth/passwords_controller.rb:
    Upstream refactored, changing lines textually close of glitch-soc-only lines
    pertaining to the theming system.
    Resolved the conflict.
  • app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb:
    Upstream refactored, changing lines textually close of glitch-soc-only lines
    pertaining to the theming system.
    Resolved the conflict.

mjankowski and others added 5 commits January 25, 2024 15:13
…oc/merge-upstream

Conflicts:
- `app/controllers/auth/confirmations_controller.rb`:
  Upstream refactored, changing lines textually close of glitch-soc-only lines
  pertaining to the theming system.
  Resolved the conflict.
- `app/controllers/auth/passwords_controller.rb`:
  Upstream refactored, changing lines textually close of glitch-soc-only lines
  pertaining to the theming system.
  Resolved the conflict.
- `app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb`:
  Upstream refactored, changing lines textually close of glitch-soc-only lines
  pertaining to the theming system.
  Resolved the conflict.
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (420ca90) 84.85% compared to head (bf153b3) 84.85%.

Files Patch % Lines
lib/mastodon/cli/maintenance.rb 71.42% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2590   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files        1065     1065           
  Lines       28872    28879    +7     
  Branches     4660     4655    -5     
=======================================
+ Hits        24499    24506    +7     
  Misses       3173     3173           
  Partials     1200     1200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClearlyClaire ClearlyClaire marked this pull request as ready for review January 27, 2024 18:27
@ClearlyClaire ClearlyClaire merged commit a4e7cc2 into glitch-soc:main Jan 28, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants