Change status content markup to match upstream #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream adopted the media-in-CW design glitch-soc originally had.
ClearlyClaire
force-pushed
the
glitch-soc/reduce-status-markup-difference-with-upstream
branch
from
6144759 to
afdd5cc
Compare
ClearlyClaire
force-pushed
the
glitch-soc/reduce-status-markup-difference-with-upstream
branch
from
afdd5cc to
a338368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors and changes how content warnings and media are handled, to better match upstream in terms of code, design and markup.
This is in order to reduce maintenance complexity and improve compatibility with custom themes such as TangerineUI.
In the process, this drops the option to put media outside of Content Warnings. This option was previously added to mimic upstream's behavior at a time upstream displayed media outside of Content Warnings while glitch-soc displayed them within Content Warnings. Upstream has since changed its design to put media under the Content Warnings, just like glitch-soc's default behavior.