[Glitch] Standalone share page: Dispatch fetchServer for maxChars #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
approved these changes
Jan 5, 2025
It is easier for me to have the thing merged upstream and then backport it when I merge upstream changes. It is also easier for us upstream to properly credit the author if they are also the person who opened the PR. But I'll handle it if you don't want to contribute directly upstream. |
|
@ClearlyClaire in case it is easier to first upstream to vanilla, well, guess I'm opening a pull request |
|
@ClearlyClaire PR opened @ mastodon#33459 |
kescherCode
force-pushed
the
glitch-pr/fix-standalone-share-maxChars
branch
from
8fbc748 to
2eaa906
Compare
|
I have also, accordingly, adjusted this PR to be a glitch-only commit. |
kescherCode
changed the title
ClearlyClaire
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2687
Regression was introduced in 6da6996, since we no longer include the maximum character count in the initial state, instead, it is fetched separately via the server details.
This may be worth upstreaming, as they'll likely have the same bug
(however, I won't be the one to do open a PR there. Have fun with it, this is AGPLv3 after all ^-^). As such, I have also modified the vanilla part of this code in this PR.