Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes up to b1a584d252f4df4c2a1a9400d6588b4f36768216 #2976

Merged
merged 37 commits into from
Feb 25, 2025

Conversation

ClearlyClaire
Copy link

Conflicts

  • app/lib/feed_manager.rb:
    Not a real conflict, but glitch-soc has an extra populate_direct_feed method.
    Added upstream's code.
    In addition, upstream changed how notifications from follow subscriptions were handled, refactoring this file in the process.
    Ported upstream's changes.
  • app/services/precompute_feed_service.rb:
    Not a real conflict, glitch-soc has extra code for the direct feed.
    Added upstream's new code for populating lists.
  • app/validators/poll_options_validator.rb:
    Upstream split PollValidator in two, and glitch-soc had local changes to make the options configurable.
    Refactored as upstream did, keeping glitch-soc's configurable limits.
  • app/workers/feed_insert_worker.rb:
    Upstream changed how notifications from follow subscriptions were handled, refactoring this file in the process.
    Conflict is due to glitch-soc having an extra timeline type (direct).
    Ported upstream's changes.

Ported changes

Postponed / To investigate

  • 7ad9581 (not sure why I never ported it to main)

ClearlyClaire and others added 30 commits February 25, 2025 17:11
ClearlyClaire and others added 7 commits February 25, 2025 17:11
…oc/merge-4.3

Conflicts:
- `app/lib/feed_manager.rb`:
  Not a real conflict, but glitch-soc has an extra `populate_direct_feed` method.
  Added upstream's code.
  In addition, upstream changed how notifications from follow subscriptions were
  handled, refactoring this file in the process.
  Ported upstream's changes.
- `app/services/precompute_feed_service.rb`:
  Not a real conflict, glitch-soc has extra code for the direct feed.
  Added upstream's new code for populating lists.
- `app/validators/poll_options_validator.rb`:
  Upstream split `PollValidator` in two, and glitch-soc had local changes to
  make the options configurable.
  Refactored as upstream did, keeping glitch-soc's configurable limits.
- `app/workers/feed_insert_worker.rb`:
  Upstream changed how notifications from follow subscriptions were handled,
  refactoring this file in the process.
  Conflict is due to glitch-soc having an extra timeline type (direct).
  Ported upstream's changes.
@ClearlyClaire ClearlyClaire merged commit adee65a into stable-4.3 Feb 25, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants