-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the “unfold thread” feature from Mastodon's UI to glitch-soc flavour #401
Port the “unfold thread” feature from Mastodon's UI to glitch-soc flavour #401
Conversation
f5aae55
to
ad830db
Compare
Porting this feature really is a pain, in terms of user interface, because of collapsed toots. The crux of the problem is the following:
In the current state of this PR, point 3 is ignored, and the “CW unfolded but collapsed view” state is possible, which is a regression. |
fed2aa6
to
adf1274
Compare
Yeah I am not a fan of having CW folding status shared across every instance of the toot for a number of reasons:
I think upstream's approach to this was kinda hacky and not great from a useability perspective and results (imho) from an overreliance on Redux as a catch-all solution to every problem, which it isn't :P. Instead this should be handled via a passed prop/state from the conversation column (React idiomatic if a little complicated) or via Events (the better, cleaner solution, but not in line with any of the existing codebase). |
Alright, this is something I wasn't too sure about. I'll try to rework the PR to fold/unfold the toots in the thread view only, not using the Redux store for that. |
dbf3803
to
47bc24c
Compare
8be910b
to
967f95e
Compare
Updated to not use redux. The CW fold/unfold state is now specific to each view of the toot, unlike in tootsuite/mastodon. Tried to keep the differences with tootsuite/mastodon minimal nevertheless. |
@marrus-sh When you get a chance, can you look over these changes? |
967f95e
to
23c61b6
Compare
23c61b6
to
b383c06
Compare
This is a very much in progress PR aiming to implement he “unfold thread” feature of Mastodon (fixes #387). Unfortunately, as the code has diverged quite a bit and is pretty hard to reason about, it will take some work.