Fix math round after conversion to cents

global-121 · Dec 24, 2024 · a538fe1 · a538fe1
1 parent a704a09
commit a538fe1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/...s/121-service/src/payments/fsp-integration/intersolve-visa/intersolve-visa.api.service.ts b/...s/121-service/src/payments/fsp-integration/intersolve-visa/intersolve-visa.api.service.ts
@@ -447,7 +447,7 @@ export class IntersolveVisaApiService {
     reference: string;
   }): Promise<void> {
     const uuid = generateUUIDFromSeed(reference);
-    const amountInCent = amountInMajorUnit * 100;
+    const amountInCent = Math.round(amountInMajorUnit * 100); // Math round is needed to prevent floating point errors
 
     const transferRequestDto: TransferRequestIntersolveApiDto = {
       quantity: {

diff --git a/...service/src/payments/fsp-integration/intersolve-visa/mappers/visa-card-121-status-map.csv b/...service/src/payments/fsp-integration/intersolve-visa/mappers/visa-card-121-status-map.csv
@@ -45,3 +45,13 @@
 "SUBSTITUTED";"FALSE";"CARD_CLOSED";"Substituted";"Card has been substituted due to re-issue";
 "SUBSTITUTED";"FALSE";"CARD_EXPIRED";"Substituted";"Card has been substituted due to re-issue";
 "SUBSTITUTED";"FALSE";"";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_OK";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_BLOCKED";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"SUSPECTED_FRAUD";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_CLOSED_DUE_TO_FRAUD";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_NO_RENEWAL";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_LOST";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_STOLEN";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_CLOSED";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"CARD_EXPIRED";"Substituted";"Card has been substituted due to re-issue";
+"SUBSTITUTED";"TRUE";"";"Substituted";"Card has been substituted due to re-issue";