unit test, to ensure max payments can be removed

Signed-off-by: Ruben <[email protected]>
global-121 · Jan 13, 2025 · f4ee1c3 · f4ee1c3
1 parent f4eae9a
commit f4ee1c3
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/...s/121-service/src/registration/interfaces/validate-registration-error-object.interface.ts b/...s/121-service/src/registration/interfaces/validate-registration-error-object.interface.ts
@@ -2,5 +2,5 @@ export interface ValidateRegistrationErrorObject {
   readonly lineNumber: number;
   readonly column: string;
   readonly error: string;
-  readonly value: string | number | undefined | boolean;
+  readonly value: string | number | undefined | boolean | null;
 }
diff --git a/services/121-service/src/registration/validators/registrations-input-validator.spec.ts b/services/121-service/src/registration/validators/registrations-input-validator.spec.ts
@@ -148,6 +148,8 @@ describe('RegistrationsInputValidator', () => {
       id: 1,
       name: 'Test Program',
       languages: ['en'],
+      enableMaxPayments: true,
+      enableScope: true,
       programFinancialServiceProviderConfigurations: [
         {
           financialServiceProviderName:
@@ -324,4 +326,26 @@ describe('RegistrationsInputValidator', () => {
       },
     ]);
   });
+
+  it('should add max payment when its null', async () => {
+    const csvArray = [
+      {
+        maxPayments: null,
+      },
+    ];
+
+    const result = await validator.validateAndCleanInput({
+      registrationInputArray: csvArray,
+      programId,
+      userId,
+      typeOfInput: RegistrationValidationInputType.update,
+      validationConfig: {
+        validateExistingReferenceId: true,
+        validatePhoneNumberLookup: true,
+        validateUniqueReferenceId: true,
+      },
+    });
+
+    expect(result[0]).toHaveProperty('maxPayments');
+  });
 });
diff --git a/services/121-service/src/registration/validators/registrations-input-validator.ts b/services/121-service/src/registration/validators/registrations-input-validator.ts
@@ -24,7 +24,7 @@ import { RegistrationsPaginationService } from '@121-service/src/registration/se
 import { LanguageEnum } from '@121-service/src/shared/enum/language.enums';
 import { UserService } from '@121-service/src/user/user.service';
 
-type InputAttributeType = string | boolean | number | undefined;
+type InputAttributeType = string | boolean | number | undefined | null;
 
 @Injectable()
 export class RegistrationsInputValidator {
@@ -888,7 +888,7 @@ export class RegistrationsInputValidator {
     attribute,
     i,
   }: {
-    value: string[] | string | number | boolean | undefined;
+    value: string[] | string | number | boolean | undefined | null;
     type: string;
     attribute: string;
     i: number;
@@ -932,15 +932,15 @@ export class RegistrationsInputValidator {
     attribute,
   }: {
     type: string;
-    value: string[] | string | number | boolean | undefined;
+    value: string[] | string | number | boolean | undefined | null;
     attribute: string;
   }): string {
     const valueString = Array.isArray(value) ? JSON.stringify(value) : value;
     return `The value '${valueString}' given for the attribute '${attribute}' does not have the correct format for type '${type}'`;
   }
 
   private valueIsBool(
-    value: string[] | string | number | boolean | undefined,
+    value: string[] | string | number | boolean | undefined | null,
   ): boolean {
     if (typeof value === 'boolean') {
       return true;