-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scoped repo refactor #6270
Merged
Merged
Scoped repo refactor #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f22c6a
to
cb7d3a7
Compare
RubenGeo
commented
Dec 9, 2024
PeterSmallenbroek
requested changes
Dec 10, 2024
1a31d69
to
a072f34
Compare
1eb177f
to
071a76c
Compare
071a76c
to
3a283fe
Compare
6f908dc
to
6bb4f7e
Compare
6bb4f7e
to
4420f0a
Compare
PeterSmallenbroek
approved these changes
Dec 19, 2024
Signed-off-by: Ruben <[email protected]>
Co-authored-by: Peter Smallenbroek <[email protected]>
Signed-off-by: Ruben <[email protected]>
4420f0a
to
eb49341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#32022
This refactor is needed because we sort of initialized scoped repository twice in the old appoach:
Here
RegistrationDataScopedRepository
already extentsScopedRepository
passing it in as argument in the constructor is giving ScopedRepository another ScopedRepository. It's like wrapping it twice. I think it never gave us issues because the internal defined methods (like 'findOne') are also overwritten twice.Describe your changes
Checklist before requesting a review