Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for do payment in portalicious #6284

Merged
merged 24 commits into from
Dec 20, 2024

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Dec 12, 2024

AB#31974

Describe your changes

Adds 2 tests:

  • Successful payment
  • Payment Summary
  • Payment for Excel FSP

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Note for the reviewer:

When I started writing those tests the details from Figma and deliverables were a bit different and did not include this screen:

Screenshot 2024-12-16 at 2 43 32 PM

Should this also be validated in the payment flow or is this a case for different test?

@Piotrk39 Piotrk39 added chore Something that does not affect the end user portalicious Changes related to the portalicious release labels Dec 12, 2024
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-tests-for-do-payment-in-portalicious branch from 3238914 to f5dfece Compare December 16, 2024 13:12
@Piotrk39 Piotrk39 marked this pull request as ready for review December 16, 2024 13:39
@aberonni aberonni self-requested a review December 17, 2024 20:37
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE: your note for the reviewer: Indeed the "View payment" page is in a separate PBI: https://dev.azure.com/redcrossnl/121%20Platform/_workitems/edit/30647

@Piotrk39
Copy link
Contributor Author

Piotrk39 commented Dec 18, 2024

RE: your note for the reviewer: Indeed the "View payment" page is in a separate PBI: https://dev.azure.com/redcrossnl/121%20Platform/_workitems/edit/30647

@aberonni I'll create a separate E2E tests and scenarios for this.

Piotrk39 and others added 23 commits December 20, 2024 13:15
* Add summary validation for excel fsp

* portalicious: refetch payment summary card data when payment is in progress (#6308)

---------

Co-authored-by: Domenico Gemoli <[email protected]>
@Piotrk39 Piotrk39 force-pushed the feat.add-e2e-tests-for-do-payment-in-portalicious branch from f29fb5b to 75e5d65 Compare December 20, 2024 12:15
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are passing, I'm not gonna question it anymore 😄

@aberonni aberonni merged commit 436dae5 into main Dec 20, 2024
9 checks passed
@aberonni aberonni deleted the feat.add-e2e-tests-for-do-payment-in-portalicious branch December 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user portalicious Changes related to the portalicious release
Development

Successfully merging this pull request may close these issues.

3 participants