Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nedbank implementation #6293

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Added nedbank implementation #6293

merged 5 commits into from
Feb 7, 2025

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Dec 16, 2024 •
edited
Loading

AB#30631

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Copilot Copilot bot review requested due to automatic review settings December 16, 2024 13:22
Copilot
Copilot AI reviewed Dec 16, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@RubenGeo RubenGeo added the enhancement New feature or request that affects our end users label Jan 9, 2025
@RubenGeo RubenGeo changed the title Added nedbank to fsp enum to add an initial commit Added nedbank implementation Jan 10, 2025
diderikvw
diderikvw requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost mid-way through, already delivering to Ruben for processing.

services/.env.example Outdated Show resolved Hide resolved
services/.env.example Outdated Show resolved Hide resolved
services/121-service/.gitignore Outdated Show resolved Hide resolved
services/121-service/src/cronjob/cronjob.service.ts Show resolved Hide resolved
services/121-service/src/cronjob/cronjob.service.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-get-order-reponse.dto.ts Outdated Show resolved Hide resolved
diderikvw
diderikvw requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delivering review of Nedbank Module, except for unit tests. Small refactor stuff I think, except for the idempotency key, which may need a conversation to decide on what is optimal.

services/121-service/src/payments/fsp-integration/nedbank/nedbank.module.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank.service.ts Outdated Show resolved Hide resolved
...1-service/src/payments/fsp-integration/nedbank/dtos/create-order-request-body-nedbank.dto.ts Outdated Show resolved Hide resolved
...s/121-service/src/payments/fsp-integration/nedbank/interfaces/nedbank-create-order-params.ts Outdated Show resolved Hide resolved
...s/121-service/src/payments/fsp-integration/nedbank/interfaces/nedbank-create-order-params.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-voucher.entity.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-voucher.entity.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Show resolved Hide resolved
diderikvw
diderikvw reviewed Jan 16, 2025
View reviewed changes
services/.env.example Outdated Show resolved Hide resolved
services/.env.example Outdated Show resolved Hide resolved
...s/121-service/src/reconciliation/nedbank-reconciliation/nedbank-reconciliation.controller.ts Outdated Show resolved Hide resolved
...ices/121-service/src/reconciliation/nedbank-reconciliation/nedbank-reconciliation.service.ts Outdated Show resolved Hide resolved
...s/121-service/src/reconciliation/nedbank-reconciliation/nedbank-reconciliation.controller.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-api.service.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-api.service.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-api.service.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Show resolved Hide resolved
diderikvw
diderikvw previously approved these changes Feb 5, 2025
View reviewed changes
@RubenGeo RubenGeo enabled auto-merge (squash) February 6, 2025 09:48
@RubenGeo RubenGeo requested a review from diderikvw February 6, 2025 13:06
Ruben and others added 5 commits February 7, 2025 16:22
@RubenGeo
Added nedbank implementation
f62cb81 
Signed-off-by: Ruben <[email protected]>
@RubenGeo
Nedbank api test fix
2c746b7
@RubenGeo
Fix unit tests nedbank
0ed20bb
@RubenGeo
Removed azure specific readmes from our repos
3b2b6c7 
Signed-off-by: Ruben <[email protected]>
@Piotrk39 @RubenGeo
Add Nedbank k6 load test (#6436)
27cd503 
* Nedbank implementation

* Moved nedbank entity and change error message

* Add data attributes and nedbank cronjob endpoint

* Change order of cron job

* Add comments and finish first stage

* Add validation and refactor payment functions

* lower duplicate numbers for test

* Update PA multipliers

* Add fixes

* remove unused files

* Update k6/helpers/registration-default.data.js

Co-authored-by: RubenGeo <[email protected]>

* Update k6/models/programs.js

Co-authored-by: RubenGeo <[email protected]>

* Update k6/tests/payment100kRegistrationNedbank.js

Co-authored-by: RubenGeo <[email protected]>

* Update k6/tests/retryFailedJobsOnStartupDuringQueueProcessing.js

Co-authored-by: RubenGeo <[email protected]>

* Fix missing error response log

---------

Co-authored-by: Ruben <[email protected]>
Co-authored-by: RubenGeo <[email protected]>
@RubenGeo RubenGeo merged commit c0de163 into main Feb 7, 2025
8 checks passed
@RubenGeo RubenGeo deleted the feat.nedbank branch February 7, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@diderikvw diderikvw diderikvw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request that affects our end users
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubenGeo @diderikvw @Piotrk39