Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portalicious: fix navigation post create-payment #6325

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Dec 19, 2024

AB#32308

After creating a new payment, the user should be redirected to the payment page. This was not working.

This does not address the originally reported bug in the linked bug item, but that is because the bug is actually expected behaviour.

PS I also disabled the very annoying HTTP request logs

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Copilot Copilot bot review requested due to automatic review settings December 19, 2024 15:00
@aberonni aberonni added the portalicious [DEPRECATED] Changes related to the Portalicious release label Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@aberonni aberonni force-pushed the aberonni/portalicious-fix-create-payment-redirect branch from f234a1c to 6850484 Compare December 19, 2024 15:43
@aberonni aberonni force-pushed the aberonni/portalicious-fix-create-payment-redirect branch from 6850484 to e2a8444 Compare December 19, 2024 15:43
@aberonni aberonni enabled auto-merge (squash) December 19, 2024 15:50
@aberonni aberonni force-pushed the aberonni/portalicious-fix-create-payment-redirect branch from e2a8444 to 80ae2d0 Compare December 19, 2024 16:19
AB#32308

After creating a new payment, the user should be redirected to the payment page. This was not working.

This does not address the originally reported bug in the linked bug item, but that is because the bug is _actually_ expected behaviour.
@aberonni aberonni force-pushed the aberonni/portalicious-fix-create-payment-redirect branch from 80ae2d0 to b101cb2 Compare December 20, 2024 07:49
@aberonni aberonni merged commit 9b76da7 into main Dec 20, 2024
5 checks passed
@aberonni aberonni deleted the aberonni/portalicious-fix-create-payment-redirect branch December 20, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portalicious [DEPRECATED] Changes related to the Portalicious release
Development

Successfully merging this pull request may close these issues.

2 participants