portalicious: strings instead of numbers in query params #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
added
the
portalicious
There was a problem hiding this comment.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- interfaces/Portalicious/src/app/components/registration-page-layout/registration-page-layout.component.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-registration-debit-cards/project-registration-debit-cards.page.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/components/registration-page-layout/components/registration-menu/registration-menu.component.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/registration/registration.api.service.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/metric/metric.api.service.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/services/auth.service.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/registration/registration.helper.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-payments/project-payments.page.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/project/project.api.service.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/payment/payment.api.service.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-registration-personal-information/project-registration-personal-information.page.ts: Evaluated as low risk
aberonni
force-pushed
the
aberonni/portalicious-query-param-strings
branch
from
9baa4d5 to
bfb6da4
Compare
aberonni
force-pushed
the
aberonni/portalicious-query-param-strings
branch
from
bfb6da4 to
cb2e40f
Compare
aberonni
commented
Dec 20, 2024
...cious/src/app/components/page-layout/components/payment-header/payment-header.component.html
Show resolved
Hide resolved
PeterSmallenbroek
approved these changes
Dec 20, 2024
aberonni
force-pushed
the
aberonni/portalicious-query-param-strings
branch
from
cb2e40f to
9fb5697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#32359
After some digging I realised this was what was causing a 400 error on the retry payment endpoint (sending a string payment id instead of a number, but TS thought it was a number).
Checklist before requesting a review