Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update balanceUsed on getVoucherBalance AB#32465 #6353

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Jan 3, 2025

AB#32465

Describe your changes

balanceUsed was not updated on getVoucherBalance (from portal). Plus minor refactoring.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@jannisvisser jannisvisser added the chore Something that does not affect the end user label Jan 3, 2025
@jannisvisser jannisvisser force-pushed the fix.update-balanceUsed-on-getVoucherBalance branch from 65c8b79 to 0b6de33 Compare January 3, 2025 13:10
@RubenGeo RubenGeo force-pushed the fix.update-balanceUsed-on-getVoucherBalance branch from 0b6de33 to 1b096c1 Compare January 6, 2025 07:36
@RubenGeo RubenGeo self-requested a review January 6, 2025 07:36
@RubenGeo RubenGeo enabled auto-merge (squash) January 6, 2025 07:36
@RubenGeo RubenGeo merged commit eac23cb into main Jan 6, 2025
6 checks passed
@RubenGeo RubenGeo deleted the fix.update-balanceUsed-on-getVoucherBalance branch January 6, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants