Get exchange rates #6392
Merged
Get exchange rates #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (5)
- services/121-service/swagger.json: Language not supported
- services/121-service/src/exchange-rates/dtos/get-exchange-rate.dto.ts: Evaluated as low risk
- services/121-service/src/exchange-rates/exchange-rates.api.service.ts: Evaluated as low risk
- services/121-service/src/exchange-rates/exchange-rates.controller.ts: Evaluated as low risk
- services/121-service/src/exchange-rates/exchange-rates.module.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
services/121-service/src/exchange-rates/exchange-rates.service.spec.ts:15
- The test descriptions should be updated to reflect the new service name 'ExchangeRatesService'.
describe('ExchangeRatesService', () => {
RubenGeo
commented
Jan 16, 2025
PeterSmallenbroek
requested changes
Jan 16, 2025
services/121-service/src/exchange-rates/exchange-rates.controller.ts
Outdated
Show resolved
Hide resolved
…ler.ts Co-authored-by: Peter Smallenbroek <[email protected]>
PeterSmallenbroek
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#32743
Describe your changes
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.