Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portalicious: open registration in new tab #6411

Merged
merged 1 commit into from
Jan 22, 2025
Merged

portalicious: open registration in new tab #6411

merged 1 commit into from
Jan 22, 2025

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Jan 22, 2025 •
edited
Loading

AB#32871

This is broken on test/production:
image

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6411.westeurope.5.azurestaticapps.net

@aberonni aberonni added the portalicious Changes related to the portalicious release label Jan 22, 2025
@aberonni aberonni marked this pull request as ready for review January 22, 2025 08:09
@Copilot Copilot bot review requested due to automatic review settings January 22, 2025 08:09
Copilot
Copilot AI reviewed Jan 22, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.ts:280

  • Ensure that the new behavior introduced by using getOriginUrl is covered by tests.
window.open(getOriginUrl() + url, '_blank');
@aberonni aberonni force-pushed the aberonni/portalicious-fix-open-link-in-new-tab branch from fcf3a91 to a004b52 Compare January 22, 2025 09:40
@arsforza arsforza self-requested a review January 22, 2025 10:35
@arsforza arsforza self-requested a review January 22, 2025 11:03
@aberonni aberonni enabled auto-merge (squash) January 22, 2025 11:41
@aberonni aberonni force-pushed the aberonni/portalicious-fix-open-link-in-new-tab branch from a004b52 to 2f38583 Compare January 22, 2025 11:41
@aberonni aberonni merged commit 0058baa into main Jan 22, 2025
6 checks passed
@aberonni aberonni deleted the aberonni/portalicious-fix-open-link-in-new-tab branch January 22, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@arsforza arsforza arsforza approved these changes

Assignees
No one assigned
Labels
portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aberonni @arsforza