Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nedbank cert readme.md #6413

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Nedbank cert readme.md #6413

merged 6 commits into from
Jan 23, 2025

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Jan 22, 2025

AB#32896

The main feat.nedbank branch has not yet been merged but I think that in the spirit of small PRs it's fine to review and merge this seperately

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@RubenGeo RubenGeo added the chore Something that does not affect the end user label Jan 22, 2025
@Copilot Copilot bot review requested due to automatic review settings January 22, 2025 10:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@RubenGeo RubenGeo requested a review from elwinschmitz January 22, 2025 10:58
Copy link
Member

@elwinschmitz elwinschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've slightly simplified the steps. (aligned with the CBE-steps.)

@RubenGeo RubenGeo force-pushed the chore.nedbank-cert-readme branch from 968d3a8 to 6ccaeb6 Compare January 23, 2025 09:35
@RubenGeo RubenGeo requested a review from elwinschmitz January 23, 2025 10:02
@elwinschmitz elwinschmitz merged commit 069e09e into main Jan 23, 2025
3 checks passed
@elwinschmitz elwinschmitz deleted the chore.nedbank-cert-readme branch January 23, 2025 13:42
elwinschmitz added a commit that referenced this pull request Jan 30, 2025
* chore: Add documentation-link

* fix: Typo in action-step name

* dx: Make sure to use closest ESLint-version

* docs: Add missing ENV-variable

* docs: Align README about certificates with other FSP

See #6413

* dx: Hide unnecessary elements in Squagger-UI

* fix: Prevent Petstore-Inception-bug

Resolves AB#24724 (hopefully, partly)

* feat: Hide useless filter-bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants