Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

121-service fix: rename endpoint & check for array #6439

Merged
merged 3 commits into from
Jan 30, 2025
Merged

121-service fix: rename endpoint & check for array #6439

merged 3 commits into from
Jan 30, 2025

Conversation

PeterSmallenbroek
Copy link
Contributor

@PeterSmallenbroek PeterSmallenbroek commented Jan 29, 2025 •
edited
Loading

AB#33157

Describe your changes

2 fixes in this PR:

  • The cron endpoint url was changed in the cronjob service but no in at the actual endpoint
  • The unused voucher cronjob tries to access the [0] element always (also if it's an empty array)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@PeterSmallenbroek PeterSmallenbroek added the chore Something that does not affect the end user label Jan 29, 2025
RubenGeo
RubenGeo previously approved these changes Jan 30, 2025
View reviewed changes
@PeterSmallenbroek PeterSmallenbroek enabled auto-merge (squash) January 30, 2025 10:06
@PeterSmallenbroek PeterSmallenbroek merged commit 96c7cc9 into main Jan 30, 2025
6 checks passed
@PeterSmallenbroek PeterSmallenbroek deleted the fix.cronjob-unused-vouchers branch January 30, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenGeo RubenGeo RubenGeo approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterSmallenbroek @RubenGeo