Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor colored chip helpers #6520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Feb 14, 2025

AB#33610

This reduces some duplication, and inadvertently fixes the transaction statuses in the activity log which were incorrect.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6520.westeurope.5.azurestaticapps.net

@aberonni aberonni added the chore Something that does not affect the end user label Feb 14, 2025
@Copilot Copilot bot review requested due to automatic review settings February 14, 2025 13:51
@aberonni aberonni enabled auto-merge (squash) February 14, 2025 13:51

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • interfaces/Portalicious/src/locale/messages.xlf: Language not supported
  • interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/activity-log-expanded-row/activity-log-expanded-row.component.ts: Evaluated as low risk
@aberonni aberonni disabled auto-merge February 14, 2025 14:59
@aberonni aberonni enabled auto-merge (squash) February 14, 2025 14:59
AB#33610

This reduces some duplication, and inadvertently fixes the transaction statuses in the activity log which were incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

1 participant