Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number: parse literals #353

Closed
6 tasks done
Tracked by #364
rxaviers opened this issue Dec 2, 2014 · 5 comments · Fixed by #656
Closed
6 tasks done
Tracked by #364

Number: parse literals #353

rxaviers opened this issue Dec 2, 2014 · 5 comments · Fixed by #656
Labels
help wanted new feature number module

Comments

@rxaviers
Copy link
Member

rxaviers commented Dec 2, 2014 •
edited
Loading

Handle literals when parsing numbers. E.g.,

Globalize.parseNumber("-$1,214.12", { pattern: "'$'#,##0.##" });

Test:

References:
@rxaviers rxaviers added this to the 1.0.0 milestone Dec 2, 2014
@rxaviers rxaviers mentioned this issue Dec 11, 2014
Open
1 task
@rxaviers rxaviers modified the milestones: 1.1.0, 1.0.0 Feb 12, 2015
@rxaviers rxaviers mentioned this issue Jun 29, 2015
Closed
@rxaviers rxaviers mentioned this issue Aug 31, 2015
Closed
@Mottie Mottie mentioned this issue Oct 2, 2015
Closed
@rxaviers rxaviers mentioned this issue Oct 10, 2015
Closed
@rxaviers rxaviers modified the milestone: 1.1.0 Oct 11, 2015
@rxaviers rxaviers mentioned this issue Nov 30, 2015
Closed
@rxaviers rxaviers mentioned this issue Feb 5, 2016
Closed
ashensis pushed a commit to ashensis/globalize that referenced this issue Mar 17, 2016
@shioyama
Use reflections or _reflections, whichever is defined.
639333e 
Not beautiful, but this should fix globalizejs#353 for now. Also see
rails/rails#15300.
@lijunle
Copy link

lijunle commented Jul 19, 2016

Hi, @rxaviers This bug is open on year 2014. Any updates on it?

@rxaviers
Copy link
Member Author

The project is out of resources and is relying on external contribution to get this feature implemented.

Having said that, this feature is still open to be included. If you're willing to contribute it, I can provide further any guidance you may need to get up to speed. Thanks.

@lijunle
Copy link

lijunle commented Jul 20, 2016

@rxaviers Could you provide some resources and ideas about how to implement this? Besides, do you have some workaround on this?

@rxaviers
Copy link
Member Author

rxaviers commented Jul 20, 2016 •
edited
Loading

The workaround is to do any parsing at user land and pass a number only to numberParser, which isn't great.

I've updated one resource link in the description. Please, let me know what you think after going through them.

One file that will need change is src/number/parse.js. The changes should be analogous to src/date/{parse, tokenizer}*.

Please, just let me know if you have any further questions.

@rxaviers rxaviers mentioned this issue Aug 17, 2016
Closed
@rxaviers rxaviers mentioned this issue Oct 24, 2016
Closed
rxaviers added a commit that referenced this issue Nov 28, 2016
@rxaviers
Number Parse: Refactor for improved algorithm
be9bb9f 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
@rxaviers rxaviers mentioned this issue Nov 28, 2016
Merged
@rxaviers
Copy link
Member Author

rxaviers commented Nov 28, 2016 •
edited
Loading

PR #656 in place :)

rxaviers added a commit that referenced this issue Nov 28, 2016
@rxaviers
Number Parser: Refactor for improved algorithm
4f6b05a 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that are related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Globalize-compiler example: bump up globalize-compiler version
1eebde9 
Ref #292
Ref #353
Ref globalizejs/globalize-compiler#20
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Number Parser: Refactor for improved algorithm
bba6a5e 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that are related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Globalize-compiler example: bump up globalize-compiler version
3f096f2 
Ref #292
Ref #353
Ref globalizejs/globalize-compiler#20
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Number Parser: Refactor for improved algorithm
637cbd3 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that are related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Globalize-compiler example: bump up globalize-compiler version
ab653f9 
Ref #292
Ref #353
Ref globalizejs/globalize-compiler#20
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Docs: Update number module size
6458f15 
Ref #353
rxaviers added a commit that referenced this issue Dec 14, 2016
@rxaviers
Runtime: Add missing removeLiteralQuotes reference
b04cdb3 
Amend "Refactor for improved algorithm"

Ref #292
Ref #353
rxaviers added a commit that referenced this issue Dec 30, 2016
@rxaviers
Number Parser: Remove unnecessary regular expression part
f0effa9 
Ref #292
Ref #353
rxaviers added a commit that referenced this issue Dec 30, 2016
@rxaviers
Number: Fix parser to test the whole grammar statement
6bf2db2 
Fixes #660
Ref #292
Ref #353
rxaviers added a commit that referenced this issue Dec 31, 2016
@rxaviers
Number Parser: Remove unnecessary regular expression part
1daba30 
Ref #292
Ref #353
rxaviers added a commit that referenced this issue Dec 31, 2016
@rxaviers
Number: Fix parser to test the whole grammar statement
2b329f4 
Fixes #660
Ref #292
Ref #353
@rxaviers rxaviers mentioned this issue Jan 16, 2017
Closed
rxaviers added a commit to rxaviers/globalize that referenced this issue Feb 20, 2017
@rxaviers
Number: Fix parser to handle empty string
b1745f1 
Fixes globalizejs#682
Ref globalizejs#292
Ref globalizejs#353
@rxaviers rxaviers mentioned this issue Feb 20, 2017
Merged
rxaviers added a commit to rxaviers/globalize that referenced this issue Feb 23, 2017
@rxaviers
Number: Fix parser to handle empty string
fd84850 
Fixes globalizejs#682
Ref globalizejs#292
Ref globalizejs#353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted new feature number module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Number Parser: Refactor for improved algorithm globalizejs/globalize
2 participants
@rxaviers @lijunle