Skip to content

Commit

Permalink
Add setting to automatically show submit button (Gold872#199)
Browse files Browse the repository at this point in the history
  • Loading branch information
glolichen committed Jan 19, 2025
1 parent 06291e0 commit 913a5f0
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 19 deletions.
4 changes: 4 additions & 0 deletions lib/pages/dashboard_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1640,6 +1640,10 @@ class _DashboardPageState extends State<DashboardPage> with WindowListener {
}
setState(() {});
},
onAutoSubmitButtonChanged: (value) async {
preferences.setBool(PrefKeys.autoSubmitButton, value);
setState(() {});
},
onOpenAssetsFolderPressed: () async {
Uri uri = Uri.file(
'${path.dirname(Platform.resolvedExecutable)}/data/flutter_assets/assets/');
Expand Down
1 change: 1 addition & 0 deletions lib/services/settings.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ class PrefKeys {
static String gridDpiOverride = 'grid_dpi_override';
static String showOpenAssetsFolderWarning = "show_assets_folder_warning";
static String windowPosition = 'window_position';
static String autoSubmitButton = 'auto_submit_button';
}
2 changes: 2 additions & 0 deletions lib/widgets/nt_widgets/single_topic/text_display.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import 'package:dot_cast/dot_cast.dart';
import 'package:provider/provider.dart';

import 'package:elastic_dashboard/services/nt4_client.dart';
import 'package:elastic_dashboard/services/settings.dart';
import 'package:elastic_dashboard/widgets/dialog_widgets/dialog_toggle_switch.dart';
import 'package:elastic_dashboard/widgets/nt_widgets/nt_widget.dart';

Expand Down Expand Up @@ -38,6 +39,7 @@ class TextDisplayModel extends SingleTopicNTWidgetModel {
super.period,
}) : super() {
showSubmitButton ??= ntConnection.getTopicFromName(topic)?.isPersistent;
showSubmitButton ??= preferences.getBool(PrefKeys.autoSubmitButton);
showSubmitButton ??= false;
_showSubmitButton = showSubmitButton;
}
Expand Down
18 changes: 18 additions & 0 deletions lib/widgets/settings_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class SettingsDialog extends StatefulWidget {
final Function(String? value)? onDefaultGraphPeriodChanged;
final Function(FlexSchemeVariant variant)? onThemeVariantChanged;
final Function(String? value)? onGridDPIChanged;
final Function(bool value)? onAutoSubmitButtonChanged;
final Function()? onOpenAssetsFolderPressed;

const SettingsDialog({
Expand All @@ -60,6 +61,7 @@ class SettingsDialog extends StatefulWidget {
this.onDefaultGraphPeriodChanged,
this.onThemeVariantChanged,
this.onGridDPIChanged,
this.onAutoSubmitButtonChanged,
this.onOpenAssetsFolderPressed,
});

Expand Down Expand Up @@ -209,6 +211,22 @@ class _SettingsDialogState extends State<SettingsDialog> {
),
],
),
Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: [
Flexible(
child: DialogToggleSwitch(
initialValue: false,
label: 'Automatically Show Submit Button',
onToggle: (value) {
setState(() {
widget.onAutoSubmitButtonChanged?.call(value);
});
},
),
)
],
),
];
}

Expand Down
38 changes: 19 additions & 19 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,10 @@ packages:
dependency: "direct main"
description:
name: collection
sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a
sha256: a1ace0a119f20aabc852d165077c036cd864315bd99b7eaa10a60100341941bf
url: "https://pub.dev"
source: hosted
version: "1.18.0"
version: "1.19.0"
convert:
dependency: transitive
description:
Expand Down Expand Up @@ -565,18 +565,18 @@ packages:
dependency: transitive
description:
name: leak_tracker
sha256: "7f0df31977cb2c0b88585095d168e689669a2cc9b97c309665e3386f3e9d341a"
sha256: "7bb2830ebd849694d1ec25bf1f44582d6ac531a57a365a803a6034ff751d2d06"
url: "https://pub.dev"
source: hosted
version: "10.0.4"
version: "10.0.7"
leak_tracker_flutter_testing:
dependency: transitive
description:
name: leak_tracker_flutter_testing
sha256: "06e98f569d004c1315b991ded39924b21af84cf14cc94791b8aea337d25b57f8"
sha256: "9491a714cca3667b60b5c420da8217e6de0d1ba7a5ec322fab01758f6998f379"
url: "https://pub.dev"
source: hosted
version: "3.0.3"
version: "3.0.8"
leak_tracker_testing:
dependency: transitive
description:
Expand Down Expand Up @@ -621,10 +621,10 @@ packages:
dependency: transitive
description:
name: material_color_utilities
sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a"
sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec
url: "https://pub.dev"
source: hosted
version: "0.8.0"
version: "0.11.1"
messagepack:
dependency: "direct main"
description:
Expand All @@ -637,10 +637,10 @@ packages:
dependency: transitive
description:
name: meta
sha256: "7687075e408b093f36e6bbf6c91878cc0d4cd10f409506f7bc996f68220b9136"
sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7
url: "https://pub.dev"
source: hosted
version: "1.12.0"
version: "1.15.0"
mime:
dependency: transitive
description:
Expand Down Expand Up @@ -941,7 +941,7 @@ packages:
dependency: transitive
description: flutter
source: sdk
version: "0.0.99"
version: "0.0.0"
source_gen:
dependency: transitive
description:
Expand Down Expand Up @@ -970,10 +970,10 @@ packages:
dependency: transitive
description:
name: stack_trace
sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b"
sha256: "9f47fd3630d76be3ab26f0ee06d213679aa425996925ff3feffdec504931c377"
url: "https://pub.dev"
source: hosted
version: "1.11.1"
version: "1.12.0"
stream_channel:
dependency: transitive
description:
Expand All @@ -994,10 +994,10 @@ packages:
dependency: transitive
description:
name: string_scanner
sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
sha256: "688af5ed3402a4bde5b3a6c15fd768dbf2621a614950b17f04626c431ab3c4c3"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
version: "1.3.0"
syncfusion_flutter_charts:
dependency: "direct main"
description:
Expand Down Expand Up @@ -1026,10 +1026,10 @@ packages:
dependency: transitive
description:
name: test_api
sha256: "9955ae474176f7ac8ee4e989dadfb411a58c30415bcfb648fa04b2b8a03afa7f"
sha256: "664d3a9a64782fcdeb83ce9c6b39e78fd2971d4e37827b9b06c3aa1edc5e760c"
url: "https://pub.dev"
source: hosted
version: "0.7.0"
version: "0.7.3"
timing:
dependency: transitive
description:
Expand Down Expand Up @@ -1170,10 +1170,10 @@ packages:
dependency: transitive
description:
name: vm_service
sha256: "3923c89304b715fb1eb6423f017651664a03bf5f4b29983627c4da791f74a4ec"
sha256: f6be3ed8bd01289b34d679c2b62226f63c0e69f9fd2e50a6b3c1c729a961041b
url: "https://pub.dev"
source: hosted
version: "14.2.1"
version: "14.3.0"
watcher:
dependency: transitive
description:
Expand Down

0 comments on commit 913a5f0

Please sign in to comment.