Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gh actions for testing #246

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 14, 2019

Give a brief summary of the changes.

This PR switches the CI/CD from travis-ci.org and appveyor.org, to GitHub Actions.

Testing

Tests still fail, due to a flake8 issue and an also locally broken test. With those 2 issues fixed, pyglotaran managed to pass the test suite.

TODO

Sadly for the moment we will lose some convenience services:

  • coveralls: Atm the normal clients don't support actions and the action doesn't support the coverage output of pytest-cov (see).
  • Slack integration: The there are already quite some slack action,
    I need to figure out which one to use and how to configure it. @joernweissenborn I also need access to the secret slack token.
  • Deployment: The deployment is added to the actions, but for it to work @jsnel or I need to add our PyPi token to the secrets of the glotaran/pyglotaran repo.
  • Deactivate good old travis and appveyor

Closing issues

closes #245

@s-weigand s-weigand added the Type: Tooling Tools used for the project (CI, CD, docs etc.) label Nov 14, 2019
@s-weigand s-weigand mentioned this pull request Nov 14, 2019
4 tasks
@jsnel jsnel merged commit fab6f1c into glotaran:fix_perfomance Nov 14, 2019
@s-weigand s-weigand deleted the use-github-actions branch November 14, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Tooling Tools used for the project (CI, CD, docs etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants