Do not fail fast.

glotzerlab · Jun 24, 2024 · a5e0e9a · a5e0e9a
1 parent f584ade
commit a5e0e9a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
@@ -26,6 +26,7 @@ jobs:
     name: Unit test [py${{ matrix.python }} ${{ matrix.os }}]
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest]
         python: ['39', '310', '311', '312']

diff --git a/cpp/box/Box.h b/cpp/box/Box.h
@@ -426,7 +426,7 @@ class Box
     void computeDistances(const vec3<float>* query_points, const unsigned int n_query_points,
                           const vec3<float>* points, const unsigned int n_points, float* distances) const
     {
-        assert(query_points == n_points);
+        assert(n_query_points == n_points);
         util::forLoopWrapper(0, n_query_points, [&](size_t begin, size_t end) {
             for (size_t i = begin; i < end; ++i)
             {

diff --git a/cpp/box/export_Box.cc b/cpp/box/export_Box.cc
@@ -1,6 +1,8 @@
 // Copyright (c) 2010-2024 The Regents of the University of Michigan
 // This file is from the freud project, released under the BSD 3-Clause License.
 
+#include <cassert>
+
 #include "export_Box.h"
 
 namespace nb = nanobind;