Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination in compact mode is not evenly distributed #16

Open
bdice opened this issue Mar 9, 2018 · 2 comments
Open

Pagination in compact mode is not evenly distributed #16

bdice opened this issue Mar 9, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@bdice
Copy link
Member

bdice commented Mar 9, 2018

Original report by Carl Simon Adorf (Bitbucket: csadorf, GitHub: csadorf).


In compact mode (only one module selected), the pagination is still divided by the job number, not by the actual number of cards to show per page.
This makes it awkward to navigate large data spaces, where only a few jobs have cards available.

@bdice
Copy link
Member Author

bdice commented Mar 9, 2018

Original comment by Bradley Dice (Bitbucket: bdice, GitHub: bdice).


I'm unsure what is the best action to take. This is the same problem faced earlier in issue #13, but just the one-module case.

Currently, we have the following tradeoff:

  • Pro: Switching between "list" and "grid" view currently retains the same pagination
  • Con: It comes at the cost of having empty or nearly-empty ("sparse") pages if some jobs lack cards.

If we chose a different tradeoff, then:

  • Pro: Pages would always be "dense" with content
  • Con: Switching list/grid views would have to go back to page 1, and list/grid views would have a different number and layout of pages, based on how many jobs have cards to show.

The second method is certainly more expensive, since we must determine how many total cards there are to show, across all jobs, before we can figure out how to paginate them. This might be expensive, and currently there is no way to get the number of cards that will be output by a module for a given job without actually returning the cards.

https://bitbucket.org/glotzer/signac-dashboard/issues/13/row-for-job-shown-even-if-no-cards-are#comment-43750697

@bdice
Copy link
Member Author

bdice commented Mar 9, 2018

Original comment by Carl Simon Adorf (Bitbucket: csadorf, GitHub: csadorf).


I see the issue. Let's put this on hold for now.

@bdice bdice added minor bug Something isn't working labels Jan 30, 2019
bdice added a commit that referenced this issue Apr 14, 2019
Fix/consolidate docs

Approved-by: Bradley Dice <[email protected]>
Approved-by: Carl Simon Adorf <[email protected]>
@bdice bdice removed the minor label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant