Fix bug where disabled modules don't appear in the module list. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
javierbg
pushed a commit
to javierbg/signac-dashboard
that referenced
this pull request
Nov 28, 2022
…zerlab#134) * Fix bug where disabled modules don't appear in the module list. * Update changelog.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 72.42% 72.42%
=======================================
Files 20 20
Lines 747 747
=======================================
Hits 541 541
Misses 206 206 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug from #110 where disabled modules weren't showing up in the module list.
Context
The "disabled" state means that a module is unchecked in the grid view at launch. The module should still have a checkbox that allows users to enable it for their browser session.
Tested manually on two different dashboard projects.
Checklist: