Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jinja templates for status output. #434

Merged
merged 7 commits into from
Jan 21, 2021
Merged

Fix jinja templates for status output. #434

merged 7 commits into from
Jan 21, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Jan 21, 2021

Description

Fixes a regression in status templates noted by @atravitz. Job ids and group names were not being handled correctly in the Jinja templates. This bug was introduced in #417.

We should probably add tests for status printing (possibly regression tests like we have for template submission). Tests would have caught this problem. I created issue #435.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog.

@bdice bdice requested review from a team as code owners January 21, 2021 01:31
@bdice bdice requested review from mikemhenry, yuanzhou0827 and atravitz and removed request for a team January 21, 2021 01:31
@bdice bdice added this to the v0.12.0 milestone Jan 21, 2021
@bdice bdice added the bug Something isn't working label Jan 21, 2021
Copy link
Collaborator

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it looks good! We should probably add tests for this though, since it's kind of a critical feature.

@bdice bdice enabled auto-merge (squash) January 21, 2021 02:04
@bdice bdice merged commit 8a07953 into master Jan 21, 2021
@bdice bdice deleted the fix/status-templates branch January 21, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants