Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-deb.sh #842

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update install-deb.sh #842

wants to merge 1 commit into from

Conversation

cbka
Copy link

@cbka cbka commented Jan 29, 2025

add apt update before apt-get install
this is useful when using the script in e.g. ansible environments because the install script itself becomes independent from previous operations.

Copy link
Member

@g-bougard g-bougard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cbka

I'm okay to add one apt update, but I don't think this is required after the one has been run.

@@ -92,6 +93,7 @@ echo
if $tasknetwork; then
echo "network task is requested"
echo "installing dependencies"
apt update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is required if still done on l.64.

@@ -106,6 +108,7 @@ echo
if $taskdeploy; then
echo "deploy task is requested"
echo "installing dependencies"
apt update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, I don't think this is required if still done on l.64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants