Fix Entity dropdown using "multiple" option (#12717)

* Added parenthesis to fix this error which occurs when creating an Entity multiple choice dropdown: "Uncaught Exception TypeError: array_combine(): Argument #2 ($values) must be of type array, null given in glpi10.0.3/src/Html.php at line 4857" Added Dropdown::testShow to unit test multiple choice dropdown creation on Entity's itemtype * Remove unmaintainable test. * More readable Co-authored-by: Cédric Anne <[email protected]>
glpi-project · Sep 26, 2022 · 8de64a8 · 8de64a8
1 parent d1f6316
commit 8de64a8
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/Dropdown.php b/src/Dropdown.php
@@ -155,8 +155,7 @@ public static function show($itemtype, $options = [])
             $name = $params['toadd'][$params['value']];
         } else if (
             !$params['multiple']
-            && $params['value'] > 0
-            || ($itemtype == "Entity" && $params['value'] >= 0)
+            && ($params['value'] > 0 || ($itemtype == "Entity" && $params['value'] >= 0))
         ) {
             $tmpname = self::getDropdownName($table, $params['value'], 1);