Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmanaged assets created despite checkbox being disabled. #19044

Open
2 tasks
Queritt opened this issue Feb 22, 2025 · 3 comments
Open
2 tasks

Unmanaged assets created despite checkbox being disabled. #19044

Queritt opened this issue Feb 22, 2025 · 3 comments
Labels
Milestone

Comments

@Queritt
Copy link

Queritt commented Feb 22, 2025

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

Version

10.0.18

Bug description

Even when the "Unmanaged devices" checkbox is disabled in the inventory settings, unmanaged devices are still being added during the discovery process.

Relevant log output

Page URL

No response

Steps To reproduce

No response

Your GLPI setup information

No response

Anything else?

No response

@cconard96 cconard96 added the bug label Feb 23, 2025
@cconard96
Copy link
Contributor

cconard96 commented Feb 23, 2025

It indeed looks like the config is ignored for main asset types (like Unmanaged).

public function handleItem()
{
//inject converted assets
$this->mainasset->setExtraData($this->data);
$this->mainasset->setAssets($this->assets);
$this->mainasset->checkConf($this->conf);
$item_start = microtime(true);
$this->mainasset->handle();
$this->item = $this->mainasset->getItem();
$this->addBench($this->item->getType(), 'handle', $item_start);
return;
}

@trasher
Copy link
Contributor

trasher commented Feb 24, 2025

This may solve the issue: #19045

I've not tested.

@Queritt
Copy link
Author

Queritt commented Feb 25, 2025

It works.

@trasher trasher added this to the 10.0.19 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants