feat: compose MouseInteraction with other interacts #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 61.05% 58.00% -3.06%
==========================================
Files 5 5
Lines 95 100 +5
==========================================
Hits 58 58
- Misses 37 42 +5
Continue to review full report at Codecov.
|
maartenbreddels
force-pushed
the
compose_interacts
branch
from
56d9100 to
418e000
Compare
For instance with PanZoom, for this specific case to work we should not listen the the drag events, for this we also need to filter on those.
maartenbreddels
force-pushed
the
compose_interacts
branch
from
418e000 to
0c14f69
Compare
This was referenced Mar 2, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance to make MouseInteractions work with PanZoom, for this specific case to work
we should not listen to the drag events, and for this we also need
to filter on those.
Closes #42
Closes #43
cc @pllim