Add support for ipyvolume scatter viewer #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Jupyter file chooser.
Carifio24
force-pushed
the
ipyvolume-scatter
branch
from
023c76b to
474d08a
Compare
Carifio24
force-pushed
the
ipyvolume-scatter
branch
from
7813fe7 to
6946f04
Compare
Closed
Carifio24
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for glue-jupyter's ipyvolume scatter viewer. This involved a bit of refactoring to make the scatter export methods flexible in order to support both viewer types. Currently the ipyvolume scatter export options class doesn't have any fields - the sphere geometry in ipyvolume has particular resolutions in both theta and phi, so we go with that. The same is true for the diamond geometry (it's actually just a very low-res sphere), and the box doesn't really have any options.
I couldn't get the circle2d geometry to work (it doesn't show anything for me in the viewer), but for that case we use spheres, just like vispy does.