-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to ipyvuetify 1.0 (Vuetify 2.0) #132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
+ Coverage 92.2% 92.2% +<.01%
=========================================
Files 80 80
Lines 3233 3234 +1
=========================================
+ Hits 2981 2982 +1
Misses 252 252
Continue to review full report at Codecov.
|
glue_jupyter/vuetify_layout.py
Outdated
|
||
drawer = v.NavigationDrawer(v_model=False, absolute=True, right=True, | ||
children=[sidebar_button, | ||
options_panel], width=350) | ||
options_panel], width=373) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this magic number? should we add a comment in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with the W5 notebook. However, I'm getting some weird behavior with the XOR selection option. Mainly, after a selection has been made, when I click somewhere else on the plot, the selection disappears. Perhaps @astrofrog knows a bit more, but it seems like the selection behavior is active even for that single click outside the region.
Also, I know this isn't glue-jupyter specific, but I'd like to say that there is a certain awkwardness to the scoped slots behavior... having two children lists feels weird to me. I have some ideas from a user perspective, but I can open a discussion issue on ipyvuetify.
Otherwise, looks good!
I checked, but this behavior is already in master.
It's ipyvue specific. I agree that is awkward, but I have to say that scoped slots are awkward by itself, and putting them as template-children (at the same level as the content of e.g. v-menu) is also quite unintuitive. Our reasoning was the following. Either we completely model it like vue, so scoped slots would be children, wrapped by a The way we implemented scoped slots in ipvue 1.0, is (we think) more Pythonic. But, if you have better ideas we are all ears, if we can make it even easier, that would be a win for all. Given that this PR doesn't change behaviour, and upgrades only to ipyvuetify1.0/vuetify2, I think we can merge this. |
This css feature is not yet supported on Edge, but soon will be when Edge will be based on Chromium.
8612140
to
c0d9f8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
No description provided.