Make limits cache private for serialization #474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #471 by using the first approach mentioned in that issue - changing
limits_cache
->_limits_cache
so that it isn't serialized. As mentioned in #471, this matches the structure of the VisPy viewer states.I suppose this is a breaking change as it's changing the name of the class member. I would imagine that there aren't any clients directly manipulating the limits cache, but if there are I'm happy to use the second approach mentioned in the issue instead.