Improve plugin loading #1487
Merged
Improve plugin loading #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requirement check which causes issues for users for unimportant dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import entry point manually instead of using .load() to bypass strict requirement check which causes issues for users for unimportant dependencies. For example, a common error type would be:
whereas importing astropy directly would work, so users would be confused. This often indicates an environment in which there may be conda and pip versions of packages. In most cases it's safer to just proceed and not check the versions of all the requirements of requirements, as this is what would happen anyway if importing e.g. astropy directly.