Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial setup for custom glue-solar splash screen #2139

Closed
wants to merge 1 commit into from
Closed

[WIP] Initial setup for custom glue-solar splash screen #2139

wants to merge 1 commit into from

Conversation

kakirastern
Copy link

Description

To form part of GSoC 2020 glue-solar project. The goal is to enable a custom glue-solar splash screen in lieu of the default glue one if the glue-solar plugin has been detected, if such an operation is permissible.

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #2139 into master will decrease coverage by 0.06%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
- Coverage   87.99%   87.92%   -0.07%     
==========================================
  Files         245      248       +3     
  Lines       22322    22356      +34     
==========================================
+ Hits        19642    19657      +15     
- Misses       2680     2699      +19     
Impacted Files Coverage Δ
glue/plugins/glue_solar/qt/splash_screen.py 31.03% <31.03%> (ø)
glue/plugins/glue_solar/qt/__init__.py 50.00% <50.00%> (ø)
glue/plugins/glue_solar/__init__.py 100.00% <100.00%> (ø)
glue/viewers/matplotlib/qt/widget.py 81.81% <0.00%> (+3.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656ddb7...b532d0c. Read the comment docs.

@kakirastern
Copy link
Author

Looks like the logic used in the PR will not work with the current setup of glue, so mentors have recommended against it. Will consider the possibility of developing a custom viewer in the near future.

@astrofrog
Copy link
Member

@kakirastern - thanks! For now I'll close this, but an alternative if you really want to customize the splash screen would be to make it easier to customize the path to the image used to replace the current splash screen

@astrofrog astrofrog closed this May 15, 2020
@kakirastern
Copy link
Author

Thanks @astrofrog for the tip! Really appreciate it 👍

@kakirastern
Copy link
Author

Will definitely follow up with a PR based on your suggestion soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants