Add fish completion script

[dwhinham]

[gmcn42]

Haha, from what I see in your animation fish definitely wins in the eye-candy department! Thanks for the script!

Now that we're at it, I decided to try a zsh-specific script as well, works fine:

It has also a description feature like fish. Comparing the scripts though, I think the fish built-ins are way more elegant and readable.

Regarding the PR: How about having a directory linux_src/completion_scripts with mt32-pi-ctl.{bash|zsh|fish} inside?
I also want to move the installation instructions away from the option descriptions in README.md

If that's alright with you, I'll just push the changes to this branch and merge everything when it's done. 👍

[dwhinham]

Excellent! I did wonder if zsh was the next step 🙂

Yes - one directory for all the scripts does make a lot of sense. Feel free to add whatever you like or change things as you see fit! 😀

[gmcn42]

All done! Made a 1.0.1a release containing the new scripts.

[dwhinham]

Great work!

I've updated the AUR package for Arch and all scripts are now installed to their respective locations. 🙂

[gmcn42]

I've updated the AUR package for Arch and all scripts are now installed to their respective locations.

Small observation regarding the PKGBUILD: Not sure if it's applicable to Arch but on Ubuntu the correct non-/usr/local-path for third-party zsh-completions seems to be /usr/share/zsh/vendor-completions. The zsh/site-functions dir only exists in fpath for /usr/local/share prefix, not for /usr/share.

[dwhinham]

Yeah, I caught that - I just looked to see where other packages on my system were putting their function files and went with that (/usr/share/zsh/site-functions).

/usr/local/share/zsh/site-functions is in fpath and works, but using that location on Arch doesn't seem canonical (nothing I've installed is using it).