-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core infra for RE double-loop simulation #124
Add core infra for RE double-loop simulation #124
Conversation
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 60 60
Lines 6826 6826
=======================================
Hits 6469 6469
Misses 357 357 Continue to review full report at Codecov.
|
Shouldn't test_multiperiod_wind_battery_doubleloop.py also be added? |
@dguittet thanks for bringing this up. Without knowing the details of the code being tested, I can already see that Therefore, I would suggest to merge this in (so that it can make it into the release candidate today) and add the test file in another PR later. |
@lbianchi-lbl can we use cbc instead then? |
@lbianchi-lbl Adding it in a later PR works too. |
I think so, assuming that (an appropriate version of) |
Addresses issue:
Address the first task here: #95 (comment)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: