Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core infra for RE double-loop simulation #124

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

xiangao1
Copy link
Contributor

Addresses issue:

Address the first task here: #95 (comment)

Summary/Motivation:

  • Add the necessary functions and classes for renewable case study double loop simulation.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@xiangao1 xiangao1 requested review from adowling2 and dguittet June 28, 2022 19:11
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #124 (9b93eda) into main (d034a77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          60       60           
  Lines        6826     6826           
=======================================
  Hits         6469     6469           
  Misses        357      357           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d034a77...9b93eda. Read the comment docs.

@xiangao1 xiangao1 requested a review from adowling2 June 30, 2022 16:34
@dguittet
Copy link
Contributor

Shouldn't test_multiperiod_wind_battery_doubleloop.py also be added?

@lbianchi-lbl
Copy link
Contributor

Shouldn't test_multiperiod_wind_battery_doubleloop.py also be added?

@dguittet thanks for bringing this up. Without knowing the details of the code being tested, I can already see that test_multiperiod_wind_battery_doubleloop.py won't work out of the box (e.g. explicitly requesting gurobi as the solver).

Therefore, I would suggest to merge this in (so that it can make it into the release candidate today) and add the test file in another PR later.

@xiangao1
Copy link
Contributor Author

@lbianchi-lbl can we use cbc instead then?

@dguittet
Copy link
Contributor

@lbianchi-lbl Adding it in a later PR works too.

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl can we use cbc instead then?

I think so, assuming that (an appropriate version of) cbc is available after running idaes get-extensions on both Windows and Ubuntu.

@lbianchi-lbl lbianchi-lbl merged commit c038c4e into gmlc-dispatches:main Jun 30, 2022
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jul 18, 2022
@lbianchi-lbl lbianchi-lbl mentioned this pull request Aug 8, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants