Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI infrastructure for Jupyter notebooks to dispatches-nbcheck 0.2.x #189

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Addresses issue: #181

Summary/Motivation:

Changes proposed in this PR:

  • Add nbcheck to dev requirements
  • Update notebooks-checks.yml GHA workflow file to use features from nbcheck 0.2.x
  • Update default flags in pytest.ini

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added enhancement New feature or request Priority:High High Priority Issue or PR labels Mar 29, 2023
@lbianchi-lbl lbianchi-lbl self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3cad6e1) 93.74% compared to head (1b353f7) 93.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files          59       59           
  Lines        7130     7130           
=======================================
  Hits         6684     6684           
  Misses        446      446           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbianchi-lbl
Copy link
Contributor Author

For some reason (possibly a GHA service degradation?), the jobs are showing up as still pending even though they have completed:

image

The only failure is the expected RE DoubleLoopOptimization.ipynb Cell 10 timeout, which should be addressed by #181 (and possibly setting a slightly larger value in the GHA workflow). Therefore, I'll go ahead and merge this in so that these changes can be incorporated into #181.

@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review March 29, 2023 14:58
@lbianchi-lbl lbianchi-lbl merged commit 170f534 into gmlc-dispatches:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:High High Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant