Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jq implementation #426

Merged
merged 23 commits into from
Oct 2, 2023
Merged

Add Jq implementation #426

merged 23 commits into from
Oct 2, 2023

Conversation

satabin
Copy link
Member

@satabin satabin commented Dec 8, 2022 •
edited
Loading

This adds a jq-like streaming implementation to fs2-data, based on transducers.

  • Add Jq AST
  • jq compilation to ESP
    • Add Jq AST to Query transformation
    • Provide all required type classes
  • Add jq syntax parser
    • Add jq interpolators
  • Write documentation

Closes #371

@satabin satabin added the json label Dec 8, 2022
@satabin satabin added this to the 1.7.0 milestone Dec 8, 2022
@satabin satabin added the enhancement New feature or request label Dec 11, 2022
@satabin satabin force-pushed the json/jq branch 3 times, most recently from be13bec to 0eebac5 Compare December 14, 2022 21:55
@satabin satabin modified the milestones: 1.7.0, 1.8.0 Mar 21, 2023
@satabin satabin force-pushed the json/jq branch 2 times, most recently from 4860111 to e5ffe9c Compare April 29, 2023 12:15
@satabin satabin modified the milestones: 1.8.0, 1.9.0 Jul 17, 2023
@satabin satabin marked this pull request as ready for review October 1, 2023 17:51
@satabin satabin requested a review from a team as a code owner October 1, 2023 17:51
ybasket
ybasket reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good, left a few minor comments to be resolved.

build.sbt Outdated Show resolved Hide resolved
json/src/main/scala/fs2/data/json/jq/TaggedMatcher.scala Outdated Show resolved Hide resolved
json/src/main/scala/fs2/data/json/jq/internal/ESPCompiledJq.scala Outdated Show resolved Hide resolved
json/src/main/scala/fs2/data/json/jq/internal/FusedESPCompiledJq.scala Outdated Show resolved Hide resolved
json/src/main/scala/fs2/data/json/jsonpath/internals/JsonQueryPipe.scala Show resolved Hide resolved
@satabin satabin requested a review from ybasket October 2, 2023 15:32
ybasket
ybasket approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satabin satabin merged commit f69a657 into main Oct 2, 2023
@satabin satabin deleted the json/jq branch October 2, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybasket ybasket ybasket approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request json
Projects
Deprecating the JSON Selector API
Status: Done
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Add Streaming jq Subset
2 participants
@satabin @ybasket