Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV line numbers in presence of empty rows #462

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

ybasket
Copy link
Collaborator

@ybasket ybasket commented Mar 21, 2023

Increment the line counter when an empty line in CSV input is parsed (resulting in now row).

Closes #461

Increment the line counter when an empty line in CSV input is parsed (resulting in now row).

Closes #461
@satabin satabin added bug Something isn't working csv labels Mar 21, 2023
@satabin satabin added this to the 1.7.0 milestone Mar 21, 2023
@ybasket ybasket merged commit 4a17f03 into main Mar 21, 2023
@ybasket ybasket deleted the fix/csv-line-numbers branch March 21, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong line number when CSV contains empty lines
2 participants