This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Bugfix incorrect api_key in SessionToken function #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where the verifyValidity() function checks the api token against the global api_key instead of any shop specific token. Also fixes an infinite loop error that was occurring for myself, possibly related to: gnikyt#962
|
Thanks I'll have a look.
…On Wed., Nov. 3, 2021, 08:28 Luke Walsh, ***@***.***> wrote:
@Kyon147 <https://github.com/Kyon147> requested your review on: #1001
<#1001> Bugfix incorrect
api_key in SessionToken function.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1001 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASO4OQ4YY73Q77EL7AN7BLUKEIUVANCNFSM5HDGG6GA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the verifyValidity() function checks the api token against the global api_key instead of any shop specific token.
Also fixes an infinite loop error that was occurring for myself, possibly related to: #962