Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Deprecation supports and fixes #1207

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

gnikyt
Copy link
Owner

@gnikyt gnikyt commented Sep 9, 2022

  • Fixes deprecation notices for PHP8
  • Adds deprecation logging support to tests being run

Mainly, parse_url and parse_str calls have been updated. Warnings were present complaining about possible null values where a string is expected.

This PR adjusts to check for falsey/null and use a empty string as fallback.

* Fixes deprecation notices for PHP8
* Adds deprecation logging support to tests being run
@gnikyt gnikyt added the bug Bug with the code label Sep 9, 2022
@gnikyt gnikyt self-assigned this Sep 9, 2022
@gnikyt gnikyt requested a review from Kyon147 September 9, 2022 13:22
Copy link
Collaborator

@Kyon147 Kyon147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gnikyt gnikyt merged commit 48a0b59 into master Sep 9, 2022
@gnikyt gnikyt deleted the bugfix/php8-deprecated-fixes branch September 9, 2022 14:30
@gnikyt
Copy link
Owner Author

gnikyt commented Sep 9, 2022

Merged. Closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants