Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Google TOTP Support #79

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Added Google TOTP Support #79

merged 4 commits into from
Sep 11, 2024

Conversation

theredcmdcraft
Copy link
Contributor

📋 Description

Please include a summary of the changes and the related issue. Explain the problem that you are solving and provide the
necessary context.

The Problem was, that if you connect to a SSH-Server which has needs a Second-Authentication-Step with the keyboard-interactive Authentication-Method, the Connection will be closed with the Error "all Authentication Methods failed". To fix fix of this Problem is to improve the handling of the keyboard-interactive Event in the ssh2-package. So that the Server will receive the keyboard-interactive Event from the ssh2-npm-package, and if this asks after a Google-Authenticator-TOTP-Code, it sends a Message via the Websocket to the Client(The Frontend), that will prompt to the user to enter the TOTP-Code which will be sended after pressing enter back to the server.

If you have any questions or if i should change anything, feel free to write me. Also for any Improvements and Bugfixes i am happy to hear from you.

🚀 Changes made to ...

  • 🔧 Server
  • 🖥️ Client
  • 📚 Documentation
  • 🔄 Other: ___

✅ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have looked for similar pull requests in the repository and found none

🔗 Related Issues

Fixes #66

@gnmyt
Copy link
Owner

gnmyt commented Sep 11, 2024

Hi! Thank you so much for your work on this this. I'll make some changes to this PR since I would prefer a more light approach on handling the event but I really like the feature. I haven't actually head much about TOTP authentication in ssh but it seems to be a thing so it will be included in the next version. Thanks again! :)

@gnmyt gnmyt changed the title Added Google TOPT Support Added Google TOTP Support Sep 11, 2024
@gnmyt gnmyt merged commit b85de17 into gnmyt:main Sep 11, 2024
1 check passed
@theredcmdcraft
Copy link
Contributor Author

Hi! Thank you so much for your work on this this. I'll make some changes to this PR since I would prefer a more light approach on handling the event but I really like the feature. I haven't actually head much about TOTP authentication in ssh but it seems to be a thing so it will be included in the next version. Thanks again! :)

Okay fine thank you for your improvements. If you need good docs to setup it ob your own server i can send you good docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Google TOTP Login via SSH
2 participants