fix(gnoland/cli): store skipFailingGenesisTxs in cfg #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
- Coverage 56.15% 55.90% -0.25%
==========================================
Files 422 421 -1
Lines 65707 65445 -262
==========================================
- Hits 36895 36590 -305
- Misses 25938 25996 +58
+ Partials 2874 2859 -15 ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Nov 29, 2023
zivkovicmilos
approved these changes
Nov 29, 2023
moul
approved these changes
Nov 29, 2023
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
When the flag `--skip-failing-genesis-txs=true` was set, we still have a panic because the flag wasn't send for the config <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the flag
--skip-failing-genesis-txs=truewas set, we still have a panic because the flag wasn't send for the configContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description