Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gno.land): add go type checking to keeper + tx simulation in gnokey #1702

Merged
merged 52 commits into from
May 13, 2024

Merge branch 'master' of github.com:gnolang/gno into dev/morgan/go-ty…

815c573
Select commit
Loading
Failed to load commit list.
Merged

feat(gno.land): add go type checking to keeper + tx simulation in gnokey #1702

Merge branch 'master' of github.com:gnolang/gno into dev/morgan/go-ty…
815c573
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 13, 2024 in 0s

54.18% (-0.78%) compared to dc6eb7d

View this Pull Request on Codecov

54.18% (-0.78%) compared to dc6eb7d

Details

Codecov Report

Attention: Patch coverage is 67.24138% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 54.18%. Comparing base (dc6eb7d) to head (815c573).

Files Patch % Lines
tm2/pkg/crypto/keys/client/maketx.go 52.38% 10 Missing ⚠️
gnovm/pkg/gnolang/store.go 46.66% 7 Missing and 1 partial ⚠️
tm2/pkg/crypto/keys/client/broadcast.go 0.00% 8 Missing ⚠️
gno.land/pkg/sdk/vm/errors.go 54.54% 5 Missing ⚠️
gno.land/pkg/sdk/vm/keeper.go 33.33% 3 Missing and 1 partial ⚠️
gnovm/pkg/gnolang/go2gno.go 95.74% 2 Missing ⚠️
tm2/pkg/crypto/keys/client/query.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1702      +/-   ##
==========================================
- Coverage   54.95%   54.18%   -0.78%     
==========================================
  Files         481      520      +39     
  Lines       67407    73038    +5631     
==========================================
+ Hits        37044    39575    +2531     
- Misses      27341    30245    +2904     
- Partials     3022     3218     +196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov