feat(gnovm): packages loader #2932
Draft
+3,524
−1,052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
github-actions
bot
added
🧾 package/realm
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
…ve download to own file Signed-off-by: Norman Meier <[email protected]>
n0izn0iz
changed the title
Signed-off-by: Norman Meier <[email protected]>
moul
reviewed
Oct 11, 2024
examples/gno.land/gno.mod
Outdated
| @@ -0,0 +1 @@ | |||
| module gno.land | |||
There was a problem hiding this comment.
do we need this file?
if we need it, please explain in a comment.
There was a problem hiding this comment.
please see #2904 (comment) and tell me what you think
There was a problem hiding this comment.
I think the best would be to have a gno.work file at repo root to support multiple modules in a monorepo
But in that case we need to implement the gno work commands
moul
reviewed
Oct 11, 2024
gnovm/tests/machine_test.go
Outdated
| @@ -40,7 +40,7 @@ func TestMachineTestMemPackage(t *testing.T) { | |||
| Name: tt.name, | |||
| F: func(t2 *testing.T) { //nolint:thelper | |||
| rootDir := filepath.Join("..", "..") | |||
| store := TestStore(rootDir, "test", os.Stdin, os.Stdout, os.Stderr, ImportModeStdlibsOnly) | |||
| store := TestStore(rootDir, "test", nil, os.Stdin, os.Stdout, os.Stderr, ImportModeStdlibsOnly) | |||
There was a problem hiding this comment.
create a variable that you set to nil, so we now what is this parameter.
moul
reviewed
Oct 11, 2024
moul
reviewed
Oct 11, 2024
gnovm/pkg/packages/download.go
Outdated
| func DownloadModule(pkgPath string, dst string) error { | ||
| modFilePath := filepath.Join(dst, ModfileName) | ||
| if _, err := os.Stat(modFilePath); os.IsNotExist(err) { | ||
| fmt.Fprintln(os.Stderr, "gno: downloading", pkgPath) |
There was a problem hiding this comment.
we usually don't use os.StdXXX, but stdouterr from a struct (io something) which is passed when needed.
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
n0izn0iz
force-pushed
the
gno-resolver
branch
from
5090ff2 to
31b92be
Compare
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Signed-off-by: Norman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Continuation of #2201
Taking #2904 into account
This implements a
Loadfunction with a similar interface to thepackages.Loadgo functionContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description