Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish master Docker images without --snapshot flag #3057

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

ajnavarro
Copy link
Contributor

No description provided.

@thehowl
Copy link
Member

thehowl commented Oct 31, 2024

@ajnavarro
Copy link
Contributor Author

@thehowl can we add a dummy v0.0.0 tag to stop this back and forth?

@thehowl
Copy link
Member

thehowl commented Oct 31, 2024

maybe let's run git tag v0.0.0 6ff6762d6 ahead of running goreleaser.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.31%. Comparing base (2873354) to head (959e214).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3057      +/-   ##
==========================================
- Coverage   63.32%   63.31%   -0.01%     
==========================================
  Files         548      548              
  Lines       78511    78511              
==========================================
- Hits        49715    49709       -6     
- Misses      25443    25448       +5     
- Partials     3353     3354       +1     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (+0.62%) ⬆️
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 67.18% <ø> (ø)
gnovm 67.88% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.33% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajnavarro
Copy link
Contributor Author

@thehowl done

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ententamos

@thehowl thehowl changed the title chore: Publish master Docker images removing --snapshot flag. ci: publish master Docker images without --snapshot flag Oct 31, 2024
@thehowl thehowl merged commit af05780 into master Oct 31, 2024
127 checks passed
@thehowl thehowl deleted the ajnavarro-patch-1 branch October 31, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants