Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-bot): avoid triage-pending if there is any tech-staff review #3574

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jan 21, 2025

After a first day of experimentation, we determined we don't want the triage-pending label on PRs that have already received a review from a tech-staff member.

Some additional changes:

  • Split between ApprovalBy and ReviewBy in reviewer.go, to distinguish between the requirements that only work with an approval and those that are more generic.
  • Don't request a team review if a member of the team already reviewed or is requested for review. (The bot was nagging a bit on some PRs because of this)

@thehowl thehowl requested a review from aeddi January 21, 2025 16:37
@thehowl thehowl self-assigned this Jan 21, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 21, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 74.31193% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tribs/github-bot/internal/requirements/reviewer.go 84.37% 9 Missing and 6 partials ⚠️
contribs/github-bot/internal/config/config.go 0.00% 8 Missing ⚠️
contribs/github-bot/internal/utils/github_const.go 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Jan 22, 2025
@thehowl thehowl merged commit b7f9f74 into gnolang:master Jan 23, 2025
89 checks passed
@thehowl thehowl deleted the dev/morgan/review-team-gh-bot-2 branch January 23, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in focus Core team is prioritizing this work
Projects
Development

Successfully merging this pull request may close these issues.

4 participants