-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reorganize gnovm/cmd/gno #3587
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: moul <[email protected]>
🛠 PR Checks Summary🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It will probably break compatibility with some current extension tools that use gno lint
. If merged, I think it would be worth mentioning this to contributors.
| go doc | gno doc | limited compatibility; see https://github.com/gnolang/gno/issues/522 | | ||
| go env | gno env | | | ||
| go fix | | | | ||
| go fmt | gno fmt | gofmt (& similar tools, like gofumpt) works on gno code. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to note that it includes import
by default compared to the original go fmt
, so it will try to format and resolve dependencies. (It should not fail)
ShortHelp: "gnofmt (reformat) package sources", | ||
LongHelp: "The `gno fmt` tool processes, formats, and cleans up `gno` source files.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should mention it here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to move transpile
, it is not useful enough to be a top-level command; though I'm unsure about lint
, it seems more useful in the day-to-day and go tool lint
seems cumbersome. repl
, I think ideally it could just be either a) the default behaviour of gno run
without arguments or b) something you enable in gno run
with a flag (so you could possibly also have a repl working on top of an existing package.
gno tool <command>
.ShortHelp
.embedmd
ingnovm/cmd/gno
's README as an example of how we should use it more frequently.