-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mod): utilize ~/.gno
dir
#652
Conversation
Mhhh. I personally dislike it when software create a new directory in my $HOME. I would rather they used I don't know if this conversation was already had previously, but if we're extending the use of GNO_HOME, I think we should consider having it elsewhere? |
What about following other standards such as the XDG_ and other well-known environment variables, in order to adhere to best practices on various systems and allow users to override the default value if desired? |
This PR does not involve creating a new folder, but rather reusing the existing one that is created and used globally for gno. Let's take a closer look at @harry-hov's work for this addition which is finally more as a merge + making gno more independent from go in terms of FS (which is good IMO). Then reevaluate if we should pursue a different approach for managing config-dirs globally. @thehowl, what are your thoughts on my previous comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the PR
We would like to ensure that @thehowl's valid concern is addressed before merging, for example, by inserting or updating issues.
Related: #462
See discussion: #479 (comment)