Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open up keybindings page on keypress #680

Open
mattrose opened this issue Nov 19, 2022 · 1 comment
Open

Open up keybindings page on keypress #680

mattrose opened this issue Nov 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mattrose
Copy link
Member

In #665 @vssdeo implemented a search feature for keybindings, and now I want to open up the preferences window directly to the keybindings page, or create a new window on Ctrl-Shift-P that would have the same contents, for easier access.
@vssdeo
Copy link
Contributor

vssdeo commented Nov 23, 2022

seems the key combo is already taken 'go_prev' : 'p'

How about : 'k', I will make the change for now.

But adding key seq to a long list of keypress function breaks my heart, If the plugin util keybind makes it to the main branch, I will take this out and may be have a shortcut plugin to handle these.

  • Also selecting of Keybindings page is being done for this specific case Page = 3
  • A notebook tab number and title map would remove this. Which can be configurable, later.

vssdeo added a commit to vssdeo/terminator that referenced this issue Nov 23, 2022
@vssdeo
[bug 680] Open up keybindings page on keypress gnome-terminator#680
98dcd0e 
- implemented the short-cut
- seems the key combo is already taken 'go_prev' : 'p'
- How about : 'k', I will make the change for now.
- But adding key seq to a long list of keypress function breaks my heart, If the plugin util keybind makes it to the main branch, I will take this out and may be have a shortcut plugin to handle these.
- Also selecting of Keybindings page is being done for this specific case Page = 3
- A notebook tab number and title map would remove this. Which can be configurable, later.
@mattrose mattrose added the enhancement New feature or request label Nov 29, 2022
mattrose added a commit that referenced this issue Nov 30, 2022
@mattrose
Merge pull request #686 from vssdeo/680-open-up-keybindings-page-on-k…
403bf54 
…eypress

[bug 680] Open up keybindings page on keypress #680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattrose @vssdeo